From: Jeff King <peff@peff.net>
Date: Fri, 04 Mar 2016 11:52:55 GMT
Subject: Re: [PATCH 2/2] t5510: do not leave changed cwd
Message-ID: <20160304115255.GB8355@sigill.intra.peff.net>
In-Reply-To: <f6499302a5dfb52bf6c9430581103da9569434a3.1457088499.git.git@drmicha.warpmail.net>

On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote:

> t5510 carefully keeps the cwd at the test root by using either subshells
> or explicit cd'ing back to the root. Use a subshell for the last
> subtest, too.

I doubt this caused the heisenbug you saw, as we should have an absolute
path for the trash-dir, and we "cd" to its containing directory before
deleting it. But this is definitely a good thing to be doing anyway, to
prevent surprises for new tests added to t5510.

-Peff