git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] lock_ref_sha1_basic: always fill old_oid while holding lock

From
Jeff King <peff@peff.net>
Date
Jan 13, 2016, 11:38 UTC
Message-ID
<20160113113837.GA9360@sigill.intra.peff.net>
In-Reply-To
<CAPig+cRHNa8b8TdoRFsYvBBOcHbJF1VCKNgmt4SYkQsMAsJjqA@mail.gmail.com>
On Tue, Jan 12, 2016 at 08:25:45PM -0500, Eric Sunshine wrote:
Show 11 quoted lines
> On Tue, Jan 12, 2016 at 4:44 PM, Jeff King <peff@peff.net> wrote:
> > Our basic strategy for taking a ref lock is:
> > [...]
> > If these run simultaneously, we'll see a lot of lock
> > contention, but each of the writes will succeed some of the
> > time. The reflog may record movements between any of the
> > three refs, but we would expect it to provide a consistent
> > log: the "from" field of each log entry should be the same
> > as the "two" field of the previous one.
> 
> s/two/to/

Whoops. Was tweaking my scripts "one" and "two" to test the race while I wrote up the commit message. :)

-Peff
Previous: Eric SunshineNext: Jeff King
Message 22 of 23 in “fix corner case with lock_ref_sha1_basic and REF_NODEREF”
  1. 0/2 fix corner case with lock_ref_sha1_basic and REF_NODEREFJeff King, Jan 11, 2016
  2. 1/2 checkout,clone: check return value of create_symrefJeff King, Jan 11, 2016
  3. Michael HaggertyJan 12, 2016
  4. Jeff KingJan 12, 2016
  5. 2/2 lock_ref_sha1_basic: handle REF_NODEREF with invalid refsJeff King, Jan 11, 2016
  6. Junio C HamanoJan 11, 2016
  7. Michael HaggertyJan 12, 2016
  8. Jeff KingJan 12, 2016
  9. Junio C HamanoJan 12, 2016
  10. 0/2 fix corner case with lock_ref_sha1_basic and REF_NODEREFJeff King, Jan 12, 2016
  11. 1/2 checkout,clone: check return value of create_symrefJeff King, Jan 12, 2016
  12. 2/2 lock_ref_sha1_basic: handle REF_NODEREF with invalid refsJeff King, Jan 12, 2016
  13. Jeff KingJan 12, 2016
  14. 2/2 lock_ref_sha1_basic: handle REF_NODEREF with invalid refsJeff King, Jan 12, 2016
  15. Junio C HamanoJan 12, 2016
  16. Jeff KingJan 12, 2016
  17. Jeff KingJan 12, 2016
  18. 0/3 fix corner cases with lock_ref_sha1_basicJeff King, Jan 12, 2016
  19. 1/3 checkout,clone: check return value of create_symrefJeff King, Jan 12, 2016
  20. 2/3 lock_ref_sha1_basic: always fill old_oid while holding lockJeff King, Jan 12, 2016
  21. Eric SunshineJan 13, 2016
  22. Jeff KingJan 13, 2016
  23. 3/3 lock_ref_sha1_basic: handle REF_NODEREF with invalid refsJeff King, Jan 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.