From: Jeff King <peff@peff.net>
Date: Wed, 13 Jan 2016 11:38:38 GMT
Subject: Re: [PATCH 2/3] lock_ref_sha1_basic: always fill old_oid while holding lock
Message-ID: <20160113113837.GA9360@sigill.intra.peff.net>
In-Reply-To: <CAPig+cRHNa8b8TdoRFsYvBBOcHbJF1VCKNgmt4SYkQsMAsJjqA@mail.gmail.com>

On Tue, Jan 12, 2016 at 08:25:45PM -0500, Eric Sunshine wrote:

> On Tue, Jan 12, 2016 at 4:44 PM, Jeff King <peff@peff.net> wrote:
> > Our basic strategy for taking a ref lock is:
> > [...]
> > If these run simultaneously, we'll see a lot of lock
> > contention, but each of the writes will succeed some of the
> > time. The reflog may record movements between any of the
> > three refs, but we would expect it to provide a consistent
> > log: the "from" field of each log entry should be the same
> > as the "two" field of the previous one.
> 
> s/two/to/

Whoops. Was tweaking my scripts "one" and "two" to test the race while I
wrote up the commit message. :)

-Peff