Re: [PATCH 1/2] checkout,clone: check return value of create_symref

From: Jeff King <peff@peff.net>
Date: Jan 12, 2016, 09:49 UTC
Message-ID: <20160112094957.GA9855@sigill.intra.peff.net>
In-Reply-To: <56947C63.8000507@alum.mit.edu>

On Tue, Jan 12, 2016 at 05:09:07AM +0100, Michael Haggerty wrote:

Show 11 quoted lines

> > This patch could go to maint. I don't know if it's worth the trouble. I
> > was unable to figure out a way to trigger this reliably (hence no
> > tests). The two ways I considered were:
> > 
> >   - "chmod -w .git", but it results in a die() already
> > 
> >   - the bug I'm fixing in 2/2; but we don't want to rely on that in our
> >     test suite, since I'm about to fix it. :-/
> 
> A locking conflict is an easy way to trigger this error:
> [...]

Thanks, that's a good suggestion; I'll add a test in the re-roll.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.