git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] stripspace: Implement --count-lines option

From
Tobias Klauser <tklauser@distanz.ch>
Date
Oct 16, 2015, 07:54 UTC
Message-ID
<20151016075413.GN11304@distanz.ch>
In-Reply-To
<vpq4mhsx7hq.fsf@grenoble-inp.fr>
On 2015-10-15 at 21:21:53 +0200, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 6 quoted lines
> Tobias Klauser <tklauser@distanz.ch> writes:
> 
> > + * comments are considered contents to be removed or not. Returns the
> > + * number of lines in the resulting buffer.
> 
> We write comments at imperative tone, hence "Return", not "Returns".

The other comments in strbuf.h used "Returns", so I went for it for consistency reasons. But the comment will be obsolete anyhow, as strbuf_stripspace() will not be changed and the functionality implemented in cmd_stripspace() as Junio suggested.

> Other than that, I agree with Junio:
> 
> * A preparatory patch introducing parse-options would make the actual
>   patch much easier to review.
Will do.
Show 5 quoted lines
> 
> * Just running strbuf_stripspace and counting the number of lines in the
>   result is much simpler. We use stripspace only on user-provided input
>   which are never really big so maintainability is more important than
>   performance.
Ditto.
Thanks
Previous: Matthieu MoyNext: Tobias Klauser
Message 18 of 19 in “stripspace: Implement and use --count-lines option”
  1. 0/3 stripspace: Implement and use --count-lines optionTobias Klauser, Oct 15, 2015
  2. 1/3 strbuf: make stripspace() part of strbufTobias Klauser, Oct 15, 2015
  3. Matthieu MoyOct 15, 2015
  4. Tobias KlauserOct 16, 2015
  5. Matthieu MoyOct 15, 2015
  6. Junio C HamanoOct 15, 2015
  7. Tobias KlauserOct 16, 2015
  8. 2/3 stripspace: Implement --count-lines optionTobias Klauser, Oct 15, 2015
  9. Matthieu MoyOct 15, 2015
  10. Tobias KlauserOct 16, 2015
  11. Tobias KlauserOct 16, 2015
  12. Matthieu MoyOct 16, 2015
  13. Junio C HamanoOct 15, 2015
  14. Tobias KlauserOct 16, 2015
  15. Junio C HamanoOct 16, 2015
  16. Tobias KlauserOct 17, 2015
  17. Matthieu MoyOct 15, 2015
  18. Tobias KlauserOct 16, 2015
  19. 3/3 git rebase -i: Use newly added --count-lines option for stripspaceTobias Klauser, Oct 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.