git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] git rebase -i: Use newly added --count-lines option for stripspace

From
Tobias Klauser <tklauser@distanz.ch>
Date
Oct 15, 2015, 12:18 UTC
Message-ID
<1444911524-14504-4-git-send-email-tklauser@distanz.ch>
In-Reply-To
<1444911524-14504-1-git-send-email-tklauser@distanz.ch>

Use the newly added --count-lines option for 'git stripspace' to count lines instead of piping the entire output to 'wc -l'.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 git-rebase--interactive.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index f01637b..c40ca90 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -120,9 +120,9 @@ mark_action_done () {
 	sed -e 1q < "$todo" >> "$done"
 	sed -e 1d < "$todo" >> "$todo".new
 	mv -f "$todo".new "$todo"
-	new_count=$(git stripspace --strip-comments <"$done" | wc -l)
+	new_count=$(git stripspace --strip-comments --count-lines <"$done")
 	echo $new_count >"$msgnum"
-	total=$(($new_count + $(git stripspace --strip-comments <"$todo" | wc -l)))
+	total=$(($new_count + $(git stripspace --strip-comments --count-lines <"$todo")))
 	echo $total >"$end"
 	if test "$last_count" != "$new_count"
 	then
@@ -1247,7 +1247,7 @@ test -s "$todo" || echo noop >> "$todo"
 test -n "$autosquash" && rearrange_squash "$todo"
 test -n "$cmd" && add_exec_commands "$todo"
 
-todocount=$(git stripspace --strip-comments <"$todo" | wc -l)
+todocount=$(git stripspace --strip-comments --count-lines <"$todo")
 todocount=${todocount##* }
 
 cat >>"$todo" <<EOF
-- 
2.6.1.145.gb27dacc
Previous: Tobias Klauser
Message 19 of 19 in “stripspace: Implement and use --count-lines option”
  1. 0/3 stripspace: Implement and use --count-lines optionTobias Klauser, Oct 15, 2015
  2. 1/3 strbuf: make stripspace() part of strbufTobias Klauser, Oct 15, 2015
  3. Matthieu MoyOct 15, 2015
  4. Tobias KlauserOct 16, 2015
  5. Matthieu MoyOct 15, 2015
  6. Junio C HamanoOct 15, 2015
  7. Tobias KlauserOct 16, 2015
  8. 2/3 stripspace: Implement --count-lines optionTobias Klauser, Oct 15, 2015
  9. Matthieu MoyOct 15, 2015
  10. Tobias KlauserOct 16, 2015
  11. Tobias KlauserOct 16, 2015
  12. Matthieu MoyOct 16, 2015
  13. Junio C HamanoOct 15, 2015
  14. Tobias KlauserOct 16, 2015
  15. Junio C HamanoOct 16, 2015
  16. Tobias KlauserOct 17, 2015
  17. Matthieu MoyOct 15, 2015
  18. Tobias KlauserOct 16, 2015
  19. 3/3 git rebase -i: Use newly added --count-lines option for stripspaceTobias Klauser, Oct 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.