git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/9] fetch: fetch submodules in parallel

From
Jeff King <peff@peff.net>
Date
Aug 31, 2015, 19:05 UTC
Message-ID
<20150831190526.GD20555@sigill.intra.peff.net>
In-Reply-To
<xmqqtwrfuw1n.fsf@gitster.mtv.corp.google.com>
On Mon, Aug 31, 2015 at 11:56:04AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> Stefan Beller <sbeller@google.com> writes:
> 
> > +static void destroy_output_mutex()
> 
> static void destroy_output_mutex(void)

Yep. Stefan, you may want to beef up the warning flags in your config.mak. For reference, I use:

  CFLAGS += -Wall -Werror
  CFLAGS += -Wdeclaration-after-statement
  CFLAGS += -Wpointer-arith
  CFLAGS += -Wstrict-prototypes
  CFLAGS += -Wvla
  CFLAGS += -Wold-style-declaration
  CFLAGS += -Wold-style-definition

though note that you will need to relax some of those if compiling older versions of git. My complete config.mak is at:

  https://github.com/peff/git/blob/meta/config/config.mak

which handles this semi-automatically (it's wildly undocumented, but I'd be happy to explain any of it if anybody is interested).

-Peff
Previous: Junio C HamanoNext: Stefan Beller
Message 29 of 33 in “Progress with git submodule”
  1. 0/9 Progress with git submoduleStefan Beller, Aug 28, 2015
  2. 1/9 submodule: implement `module_list` as a builtin helperStefan Beller, Aug 28, 2015
  3. 2/9 submodule: implement `module_name` as a builtin helperStefan Beller, Aug 28, 2015
  4. 3/9 submodule: implement `module_clone` as a builtin helperStefan Beller, Aug 28, 2015
  5. Junio C HamanoAug 31, 2015
  6. 4/9 thread-utils: add a threaded task queueStefan Beller, Aug 28, 2015
  7. 5/9 run-command: add synced outputStefan Beller, Aug 28, 2015
  8. 6/9 submodule: helper to run foreach in parallelStefan Beller, Aug 28, 2015
  9. Stefan BellerAug 28, 2015
  10. 7/9 fetch: fetch submodules in parallelStefan Beller, Aug 28, 2015
  11. Stefan BellerAug 28, 2015
  12. Jonathan NiederAug 28, 2015
  13. Junio C HamanoAug 28, 2015
  14. Stefan BellerAug 28, 2015
  15. Jonathan NiederAug 28, 2015
  16. Junio C HamanoAug 28, 2015
  17. Jeff KingAug 28, 2015
  18. Junio C HamanoAug 28, 2015
  19. Stefan BellerAug 28, 2015
  20. Jeff KingAug 28, 2015
  21. Jonathan NiederAug 28, 2015
  22. Jeff KingAug 28, 2015
  23. Stefan BellerAug 28, 2015
  24. Stefan BellerAug 28, 2015
  25. Jonathan NiederAug 28, 2015
  26. Stefan BellerAug 28, 2015
  27. Jonathan NiederAug 28, 2015
  28. Junio C HamanoAug 31, 2015
  29. Jeff KingAug 31, 2015
  30. 8/9 index-pack: Use the new worker poolStefan Beller, Aug 28, 2015
  31. 9/9 pack-objects: Use new worker poolStefan Beller, Aug 28, 2015
  32. Johannes SchindelinAug 28, 2015
  33. Stefan BellerAug 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.