git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/9] Progress with git submodule

From
Stefan Beller <sbeller@google.com>
Date
Aug 28, 2015, 16:35 UTC
Message-ID
<CAGZ79kbBfHUYJN1UBeynSAwfGhSmscarGnzSs9sZJmvN2m0VQg@mail.gmail.com>
In-Reply-To
<b5126a0a9438e8737c726d887ebc96e3@www.dscho.org>

On Fri, Aug 28, 2015 at 3:09 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 14 quoted lines
> Hi Stefan,
>
> On 2015-08-28 03:14, Stefan Beller wrote:
>
>> Stefan Beller (9):
>>   submodule: implement `module_list` as a builtin helper
>>   submodule: implement `module_name` as a builtin helper
>>   submodule: implement `module_clone` as a builtin helper
>
> Another thing that just hit me: is there any specific reason why the underscore? I think we prefer dashes for subcommands (think: cherry-pick) and maybe we want to do the same for subsubcommands...
>
> Ciao,
> Dscho
>
Junio wrote on Aug 3rd:
Show 7 quoted lines
>>>     $ git submodule--helper module_list
>>
>> Why would you use an underscore in here as opposed to a dash?
>
> Simply because the diff would be easier to read; the callers used to
> call module_list shell function, now they call the subcommand with the
> same name of submodule--helper.

I mean no user is expected to use the submodule--helper functions directly and we want to get rid of them eventually anyway (once the whole git-submodule.sh is rewritten in C we can just call the C functions instead of calling out to helpers)

Previous: Johannes Schindelin
Message 33 of 33 in “Progress with git submodule”
  1. 0/9 Progress with git submoduleStefan Beller, Aug 28, 2015
  2. 1/9 submodule: implement `module_list` as a builtin helperStefan Beller, Aug 28, 2015
  3. 2/9 submodule: implement `module_name` as a builtin helperStefan Beller, Aug 28, 2015
  4. 3/9 submodule: implement `module_clone` as a builtin helperStefan Beller, Aug 28, 2015
  5. Junio C HamanoAug 31, 2015
  6. 4/9 thread-utils: add a threaded task queueStefan Beller, Aug 28, 2015
  7. 5/9 run-command: add synced outputStefan Beller, Aug 28, 2015
  8. 6/9 submodule: helper to run foreach in parallelStefan Beller, Aug 28, 2015
  9. Stefan BellerAug 28, 2015
  10. 7/9 fetch: fetch submodules in parallelStefan Beller, Aug 28, 2015
  11. Stefan BellerAug 28, 2015
  12. Jonathan NiederAug 28, 2015
  13. Junio C HamanoAug 28, 2015
  14. Stefan BellerAug 28, 2015
  15. Jonathan NiederAug 28, 2015
  16. Junio C HamanoAug 28, 2015
  17. Jeff KingAug 28, 2015
  18. Junio C HamanoAug 28, 2015
  19. Stefan BellerAug 28, 2015
  20. Jeff KingAug 28, 2015
  21. Jonathan NiederAug 28, 2015
  22. Jeff KingAug 28, 2015
  23. Stefan BellerAug 28, 2015
  24. Stefan BellerAug 28, 2015
  25. Jonathan NiederAug 28, 2015
  26. Stefan BellerAug 28, 2015
  27. Jonathan NiederAug 28, 2015
  28. Junio C HamanoAug 31, 2015
  29. Jeff KingAug 31, 2015
  30. 8/9 index-pack: Use the new worker poolStefan Beller, Aug 28, 2015
  31. 9/9 pack-objects: Use new worker poolStefan Beller, Aug 28, 2015
  32. Johannes SchindelinAug 28, 2015
  33. Stefan BellerAug 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.