From: Jeff King <peff@peff.net>
Date: Mon, 31 Aug 2015 19:05:26 GMT
Subject: Re: [PATCH 7/9] fetch: fetch submodules in parallel
Message-ID: <20150831190526.GD20555@sigill.intra.peff.net>
In-Reply-To: <xmqqtwrfuw1n.fsf@gitster.mtv.corp.google.com>

On Mon, Aug 31, 2015 at 11:56:04AM -0700, Junio C Hamano wrote:

> Stefan Beller <sbeller@google.com> writes:
> 
> > +static void destroy_output_mutex()
> 
> static void destroy_output_mutex(void)

Yep. Stefan, you may want to beef up the warning flags in your
config.mak. For reference, I use:

  CFLAGS += -Wall -Werror
  CFLAGS += -Wdeclaration-after-statement
  CFLAGS += -Wpointer-arith
  CFLAGS += -Wstrict-prototypes
  CFLAGS += -Wvla
  CFLAGS += -Wold-style-declaration
  CFLAGS += -Wold-style-definition

though note that you will need to relax some of those if compiling older
versions of git. My complete config.mak is at:

  https://github.com/peff/git/blob/meta/config/config.mak

which handles this semi-automatically (it's wildly undocumented, but I'd
be happy to explain any of it if anybody is interested).

-Peff