git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-filter-branch.sh: clarify an error message

From
Jeff King <peff@peff.net>
Date
Jul 5, 2015, 13:07 UTC
Message-ID
<20150705130706.GA5435@peff.net>
In-Reply-To
<1436053144.3463091.315316457.1BAF8BA7@webmail.messagingengine.com>
On Sat, Jul 04, 2015 at 07:39:04PM -0400, Chris Jones wrote:
Show 7 quoted lines
> Make git filter-branch output a useful error message when a single
> commit is given instead of a range.  Currently, when given a command
> like git filter-branch --msg-filter 'echo "TEST"' -- abc123, it will
> give the message "Which ref do you want to rewrite?".  Instead, what
> is needed is a range of commits to rewrite.  This makes it give an
> error message that says "You didn't provide a valid range of
> commits".

Yeah, I agree the current message is a little confusing, and I think your message is an improvement. I wonder if we can even go a step further, like mentioning that at least one of the positive tips in your range must be a ref.

-Peff
Previous: Chris JonesNext: Johannes Schindelin
Message 2 of 5 in “git-filter-branch.sh: clarify an error message”
  1. git-filter-branch.sh: clarify an error messageChris Jones, Jul 4, 2015
  2. Jeff KingJul 5, 2015
  3. Johannes SchindelinJul 5, 2015
  4. Chris JonesJul 11, 2015
  5. Johannes SchindelinJul 11, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.