Re: [PATCH] git-filter-branch.sh: clarify an error message
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 5, 2015, 14:41 UTC
- Message-ID
- <aca69b93d8ab5f3c610d6201ed4334e1@www.dscho.org>
- In-Reply-To
- <20150705130706.GA5435@peff.net>
Hi,
On 2015-07-05 15:07, Jeff King wrote:
Show 14 quoted lines
> On Sat, Jul 04, 2015 at 07:39:04PM -0400, Chris Jones wrote: > >> Make git filter-branch output a useful error message when a single >> commit is given instead of a range. Currently, when given a command >> like git filter-branch --msg-filter 'echo "TEST"' -- abc123, it will >> give the message "Which ref do you want to rewrite?". Instead, what >> is needed is a range of commits to rewrite. This makes it give an >> error message that says "You didn't provide a valid range of >> commits". > > Yeah, I agree the current message is a little confusing, and I think > your message is an improvement. I wonder if we can even go a step > further, like mentioning that at least one of the positive tips in your > range must be a ref.
I agree, and would even further suggest to use the "did not" form instead of the abbreviated "didn't" one.
Thanks, Dscho