From: Jeff King <peff@peff.net>
Date: Sun, 05 Jul 2015 13:07:07 GMT
Subject: Re: [PATCH] git-filter-branch.sh: clarify an error message
Message-ID: <20150705130706.GA5435@peff.net>
In-Reply-To: <1436053144.3463091.315316457.1BAF8BA7@webmail.messagingengine.com>

On Sat, Jul 04, 2015 at 07:39:04PM -0400, Chris Jones wrote:

> Make git filter-branch output a useful error message when a single
> commit is given instead of a range.  Currently, when given a command
> like git filter-branch --msg-filter 'echo "TEST"' -- abc123, it will
> give the message "Which ref do you want to rewrite?".  Instead, what
> is needed is a range of commits to rewrite.  This makes it give an
> error message that says "You didn't provide a valid range of
> commits".

Yeah, I agree the current message is a little confusing, and I think
your message is an improvement. I wonder if we can even go a step
further, like mentioning that at least one of the positive tips in your
range must be a ref.

-Peff