git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/16] Convert parts of refs.c to struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Mar 20, 2015, 19:55 UTC
Message-ID
<20150320195555.GL612775@vauxhall.crustytoothpaste.net>
In-Reply-To
<xmqq8uere9aj.fsf@gitster.dls.corp.google.com>
On Fri, Mar 20, 2015 at 12:52:20PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > This is part 1 of n in converting code to use struct object_id.
> 
> OK --- 'n' up there looked funny ;-)

It is, unfortunately, a large task. I wish I could quantify it better than N, but I expect it will be a progressive task stretching out over several versions.

Show 10 quoted lines
> I'd like to see the series reviewed by those who recently worked
> heavily on the subsystem involved (namely, refs API); please do not
> forget to include area experts to Cc the next time around when you
> update the other areas with the same theme.  On the other hand, once
> the "struct object_id" design is settled and everybody agrees that
> it is good enough, those who were involved in the review of that
> framework do not necessarily have to be on the Cc list (of course
> they are welcome to participate).  But reviews by area experts are
> more important to avoid breaking the users in the individual areas
> that are now going to use the new object-id infrastructure.

Okay, I'll do that next time around. I expect to do at least one reroll, so I'll CC them with the next iteration if they don't pipe up at first.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Junio C Hamano
Message 19 of 19 in “Convert parts of refs.c to struct object_id”
  1. 00/16 Convert parts of refs.c to struct object_idbrian m. carlson, Mar 20, 2015
  2. 01/16 refs: convert struct ref_entry to use struct object_idbrian m. carlson, Mar 20, 2015
  3. 02/16 refs: convert for_each_tag_ref to struct object_idbrian m. carlson, Mar 20, 2015
  4. 03/16 refs: convert remaining users of for_each_ref_in to object_idbrian m. carlson, Mar 20, 2015
  5. 04/16 refs: convert for_each_ref_in_submodule to object_idbrian m. carlson, Mar 20, 2015
  6. 05/16 refs: convert head_ref to struct object_idbrian m. carlson, Mar 20, 2015
  7. 06/16 refs: convert for_each_ref_submodule to struct object_idbrian m. carlson, Mar 20, 2015
  8. 07/16 revision: remove unused _oid helper.brian m. carlson, Mar 20, 2015
  9. 08/16 refs: convert for_each_ref to struct object_idbrian m. carlson, Mar 20, 2015
  10. 09/16 refs: convert for_each_replace_ref to struct object_idbrian m. carlson, Mar 20, 2015
  11. 10/16 refs: convert namespaced ref iteration functions to object_idbrian m. carlson, Mar 20, 2015
  12. 11/16 refs: convert for_each_rawref to struct object_id.brian m. carlson, Mar 20, 2015
  13. 12/16 refs: rename do_for_each_ref_oid to do_for_each_refbrian m. carlson, Mar 20, 2015
  14. 13/16 refs: convert for_each_reflog to struct object_idbrian m. carlson, Mar 20, 2015
  15. 14/16 refs: rename each_ref_fn_oid to each_ref_fnbrian m. carlson, Mar 20, 2015
  16. 15/16 Remove unneeded *_oid functions.brian m. carlson, Mar 20, 2015
  17. 16/16 refs: convert struct ref_lock to struct object_idbrian m. carlson, Mar 20, 2015
  18. Junio C HamanoMar 20, 2015
  19. brian m. carlsonMar 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.