From: brian m. carlson Date: Fri, 20 Mar 2015 19:55:55 GMT Subject: Re: [PATCH 00/16] Convert parts of refs.c to struct object_id Message-ID: <20150320195555.GL612775@vauxhall.crustytoothpaste.net> In-Reply-To: On Fri, Mar 20, 2015 at 12:52:20PM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > > This is part 1 of n in converting code to use struct object_id. > > OK --- 'n' up there looked funny ;-) It is, unfortunately, a large task. I wish I could quantify it better than N, but I expect it will be a progressive task stretching out over several versions. > I'd like to see the series reviewed by those who recently worked > heavily on the subsystem involved (namely, refs API); please do not > forget to include area experts to Cc the next time around when you > update the other areas with the same theme. On the other hand, once > the "struct object_id" design is settled and everybody agrees that > it is good enough, those who were involved in the review of that > framework do not necessarily have to be on the Cc list (of course > they are welcome to participate). But reviews by area experts are > more important to avoid breaking the users in the individual areas > that are now going to use the new object-id infrastructure. Okay, I'll do that next time around. I expect to do at least one reroll, so I'll CC them with the next iteration if they don't pipe up at first. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187