git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/16] Convert parts of refs.c to struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Mar 20, 2015, 19:28 UTC
Message-ID
<1426879716-47835-1-git-send-email-sandals@crustytoothpaste.net>
This is part 1 of n in converting code to use struct object_id.

refs.c, and the for_each_ref series of functions particularly, is the source for many instances of object IDs in the codebase. Therefore, it makes sense to convert this series of functions to provide a basis for further conversions.

This series is essentially just for_each_ref and friends, the callbacks, and callers. Other parts of refs.c will be converted in a later series, so as to keep the number of patches to a reasonable size.

There should be no functional change from this patch series.

This series is based on top of the bc/object-id series in pu. The series will be rebased on next once bc/object-id makes it into next.

Available from the following repositories in either object-id-part1 or object-id-part1-pu (will be rebased):

  https://github.com/bk2204/git.git
  https://git.crustytoothpaste.net/git/bmc/git.git
brian m. carlson (16):
  refs: convert struct ref_entry to use struct object_id
  refs: convert for_each_tag_ref to struct object_id
  refs: convert remaining users of for_each_ref_in to object_id
  refs: convert for_each_ref_in_submodule to object_id
  refs: convert head_ref to struct object_id
  refs: convert for_each_ref_submodule to struct object_id
  revision: remove unused _oid helper.
  refs: convert for_each_ref to struct object_id
  refs: convert for_each_replace_ref to struct object_id
  refs: convert namespaced ref iteration functions to object_id
  refs: convert for_each_rawref to struct object_id.
  refs: rename do_for_each_ref_oid to do_for_each_ref
  refs: convert for_each_reflog to struct object_id
  refs: rename each_ref_fn_oid to each_ref_fn
  Remove unneeded *_oid functions.
  refs: convert struct ref_lock to struct object_id
 Documentation/technical/api-ref-iteration.txt |   2 +-
 bisect.c                                      |   8 +-
 builtin/branch.c                              |   4 +-
 builtin/checkout.c                            |   4 +-
 builtin/describe.c                            |  12 +--
 builtin/fetch.c                               |   6 +-
 builtin/for-each-ref.c                        |   4 +-
 builtin/fsck.c                                |  18 ++---
 builtin/name-rev.c                            |   6 +-
 builtin/pack-objects.c                        |  14 ++--
 builtin/receive-pack.c                        |   4 +-
 builtin/reflog.c                              |   8 +-
 builtin/remote.c                              |  14 ++--
 builtin/replace.c                             |  14 ++--
 builtin/rev-parse.c                           |   8 +-
 builtin/show-branch.c                         |  24 +++---
 builtin/show-ref.c                            |  16 ++--
 builtin/tag.c                                 |   8 +-
 fetch-pack.c                                  |  18 ++++-
 help.c                                        |   2 +-
 http-backend.c                                |  14 ++--
 log-tree.c                                    |  10 +--
 notes.c                                       |   2 +-
 reachable.c                                   |   4 +-
 refs.c                                        | 104 +++++++++++++-------------
 refs.h                                        |   6 +-
 remote.c                                      |   8 +-
 replace_object.c                              |   4 +-
 revision.c                                    |  18 +++--
 server-info.c                                 |   6 +-
 sha1_name.c                                   |   4 +-
 shallow.c                                     |   8 +-
 submodule.c                                   |   6 +-
 transport.c                                   |  10 +--
 upload-pack.c                                 |  28 +++----
 walker.c                                      |   4 +-
 36 files changed, 224 insertions(+), 206 deletions(-)
-- 
2.2.1.209.g41e5f3a
Next: brian m. carlson
Message 1 of 19 in “Convert parts of refs.c to struct object_id”
  1. 00/16 Convert parts of refs.c to struct object_idbrian m. carlson, Mar 20, 2015
  2. 01/16 refs: convert struct ref_entry to use struct object_idbrian m. carlson, Mar 20, 2015
  3. 02/16 refs: convert for_each_tag_ref to struct object_idbrian m. carlson, Mar 20, 2015
  4. 03/16 refs: convert remaining users of for_each_ref_in to object_idbrian m. carlson, Mar 20, 2015
  5. 04/16 refs: convert for_each_ref_in_submodule to object_idbrian m. carlson, Mar 20, 2015
  6. 05/16 refs: convert head_ref to struct object_idbrian m. carlson, Mar 20, 2015
  7. 06/16 refs: convert for_each_ref_submodule to struct object_idbrian m. carlson, Mar 20, 2015
  8. 07/16 revision: remove unused _oid helper.brian m. carlson, Mar 20, 2015
  9. 08/16 refs: convert for_each_ref to struct object_idbrian m. carlson, Mar 20, 2015
  10. 09/16 refs: convert for_each_replace_ref to struct object_idbrian m. carlson, Mar 20, 2015
  11. 10/16 refs: convert namespaced ref iteration functions to object_idbrian m. carlson, Mar 20, 2015
  12. 11/16 refs: convert for_each_rawref to struct object_id.brian m. carlson, Mar 20, 2015
  13. 12/16 refs: rename do_for_each_ref_oid to do_for_each_refbrian m. carlson, Mar 20, 2015
  14. 13/16 refs: convert for_each_reflog to struct object_idbrian m. carlson, Mar 20, 2015
  15. 14/16 refs: rename each_ref_fn_oid to each_ref_fnbrian m. carlson, Mar 20, 2015
  16. 15/16 Remove unneeded *_oid functions.brian m. carlson, Mar 20, 2015
  17. 16/16 refs: convert struct ref_lock to struct object_idbrian m. carlson, Mar 20, 2015
  18. Junio C HamanoMar 20, 2015
  19. brian m. carlsonMar 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.