Re: [PATCH 1/5] git-compat-util: add xstrdup_or_null helper

From: Jeff King <peff@peff.net>
Date: Jan 13, 2015, 02:23 UTC
Message-ID: <20150113022336.GA3927@peff.net>
In-Reply-To: <20150113022119.GA29365@google.com>

On Mon, Jan 12, 2015 at 06:21:19PM -0800, Jonathan Nieder wrote:

Show 15 quoted lines

> Jeff King wrote:
> 
> > --- a/git-compat-util.h
> > +++ b/git-compat-util.h
> > @@ -675,6 +675,11 @@ extern char *xgetcwd(void);
> >  
> >  #define REALLOC_ARRAY(x, alloc) (x) = xrealloc((x), (alloc) * sizeof(*(x)))
> >  
> > +static inline char *xstrdup_or_null(const char *str)
> > +{
> > +	return str ? xstrdup(str) : NULL;
> > +}
> 
> Would it make sense for xstrdup to always include the NULL check,
> avoiding the need for the more verbose xstrdup_or_null?

Read the rest of the thread. :)

-Peff