Re: [PATCH] Git::SVN: handle missing ref_id case correctly
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Jan 10, 2015, 22:13 UTC
- Message-ID
- <20150110221308.GA32253@dcvr.yhbt.net>
- In-Reply-To
- <CALkWK0=jEh06hZSmHim54BaP_KiC8hg-455STQphu17PSoQTqw@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> wrote:
Show 5 quoted lines
> Ramkumar Ramachandra wrote:
> > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
> > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} : 'git-svn';
>
> This is probably not a functional change; please look at the second hunk.It is functional, maybe someone will use GIT_SVN_ID=0 ?