From: Eric Wong Date: Sat, 10 Jan 2015 22:13:08 GMT Subject: Re: [PATCH] Git::SVN: handle missing ref_id case correctly Message-ID: <20150110221308.GA32253@dcvr.yhbt.net> In-Reply-To: Ramkumar Ramachandra wrote: > Ramkumar Ramachandra wrote: > > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn'; > > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} : 'git-svn'; > > This is probably not a functional change; please look at the second hunk. It is functional, maybe someone will use GIT_SVN_ID=0 ?