Re: [PATCH] Git::SVN: handle missing ref_id case correctly
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jan 10, 2015, 22:18 UTC
- Message-ID
- <CALkWK0mQCe_gUZCCnoZyNPCp=cubQcPAOSqAN0pzMA5eyYUdAQ@mail.gmail.com>
- In-Reply-To
- <CALkWK0mXx5qQSNSC4ju8Bejy_XhewxDA+nwy1JCmodX3t-H+3A@mail.gmail.com>
Ramkumar Ramachandra wrote:
>> It is functional, maybe someone will use GIT_SVN_ID=0 ? > > Right. Kindly drop the first hunk.
Amendment: there are actually many other places where variables are checked without "defined", so I doubt we want to put up with the extra ugliness to allow "0".