git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] reflog.c: use a reflog transaction when writing during expire

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 3, 2014, 03:18 UTC
Message-ID
<20141203031826.GG6527@google.com>
In-Reply-To
<1417506402-24257-5-git-send-email-sbeller@google.com>
Stefan Beller wrote:
> --- a/builtin/reflog.c
> +++ b/builtin/reflog.c
[...]
Show 6 quoted lines
> @@ -290,7 +291,7 @@ static int unreachable(struct expire_reflog_cb *cb, struct commit *commit, unsig
>  
>  static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
>  		const char *email, unsigned long timestamp, int tz,
> -		const char *message, void *cb_data)
> +		const char *message, void *cb_data, struct strbuf *err)

This doesn't match the signature of each_reflog_ent_fn. Would putting err in the cb_data struct work?

Curious, Jonathan

Previous: Stefan BellerNext: Junio C Hamano
Message 11 of 12 in “[PATCHv2 0/4] refs.c: use transactions for the reflog”
  1. Stefan BellerDec 2, 2014
  2. 1/4 refs.c: rename the transaction functionsStefan Beller, Dec 2, 2014
  3. Jonathan NiederDec 3, 2014
  4. 2/4 refs.c: rename transaction.updates to transaction.ref_updatesStefan Beller, Dec 2, 2014
  5. Jonathan NiederDec 3, 2014
  6. 3/4 refs.c: add a transaction function to append a reflog entryStefan Beller, Dec 2, 2014
  7. Jonathan NiederDec 3, 2014
  8. Stefan BellerDec 3, 2014
  9. Jonathan NiederDec 3, 2014
  10. 4/4 reflog.c: use a reflog transaction when writing during expireStefan Beller, Dec 2, 2014
  11. Jonathan NiederDec 3, 2014
  12. Junio C HamanoDec 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.