From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 03 Dec 2014 03:18:26 GMT
Subject: Re: [PATCH 4/4] reflog.c: use a reflog transaction when writing during expire
Message-ID: <20141203031826.GG6527@google.com>
In-Reply-To: <1417506402-24257-5-git-send-email-sbeller@google.com>

Stefan Beller wrote:

> --- a/builtin/reflog.c
> +++ b/builtin/reflog.c
[...]
> @@ -290,7 +291,7 @@ static int unreachable(struct expire_reflog_cb *cb, struct commit *commit, unsig
>  
>  static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
>  		const char *email, unsigned long timestamp, int tz,
> -		const char *message, void *cb_data)
> +		const char *message, void *cb_data, struct strbuf *err)

This doesn't match the signature of each_reflog_ent_fn.  Would putting
err in the cb_data struct work?

Curious,
Jonathan