git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fast-import: support the ls command anywhere comments are accepted

From
Mike Hommey <mh@glandium.org>
Date
Nov 27, 2014, 22:01 UTC
Message-ID
<20141127220143.GA2554@glandium.org>
In-Reply-To
<20141125230333.GA11114@glandium.org>
On Wed, Nov 26, 2014 at 08:03:33AM +0900, Mike Hommey wrote:
Show 18 quoted lines
> On Wed, Nov 26, 2014 at 07:25:39AM +0900, Mike Hommey wrote:
> > The git-fast-import manual page says about both cat-blob and ls that they can
> > be used "anywhere in the stream that comments are accepted", but in practice
> > it turns out it was only true for cat-blob. This change makes fast-import
> > behavior match its documentation.
> > 
> > Signed-off-by: Mike Hommey <mh@glandium.org>
> > ---
> >  fast-import.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > The downside of this change is that if a script relies on the fixed behavior,
> > it won't work with older versions of git. I'm not sure it is better than
> > fixing the documentation to match the unfortunate current limitation?
> 
> Note, if my reading of the code is correct, then cat-blob can't be used
> between filemodify | filedelete | filecopy | filerename | filedeleteall
> | notemodify either...
Any thought on whether to fix those or to fix the documentation instead?
Mike
Previous: Mike Hommey
Message 3 of 3 in “fast-import: support the ls command anywhere comments are accepted”
  1. fast-import: support the ls command anywhere comments are acceptedMike Hommey, Nov 25, 2014
  2. Mike HommeyNov 25, 2014
  3. Mike HommeyNov 27, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.