Re: [PATCH] fast-import: support the ls command anywhere comments are accepted

From: Mike Hommey <mh@glandium.org>
Date: Nov 25, 2014, 23:03 UTC
Message-ID: <20141125230333.GA11114@glandium.org>
In-Reply-To: <1416954339-9304-1-git-send-email-mh@glandium.org>

On Wed, Nov 26, 2014 at 07:25:39AM +0900, Mike Hommey wrote:

Show 13 quoted lines

> The git-fast-import manual page says about both cat-blob and ls that they can
> be used "anywhere in the stream that comments are accepted", but in practice
> it turns out it was only true for cat-blob. This change makes fast-import
> behavior match its documentation.
> 
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>  fast-import.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> The downside of this change is that if a script relies on the fixed behavior,
> it won't work with older versions of git. I'm not sure it is better than
> fixing the documentation to match the unfortunate current limitation?

Note, if my reading of the code is correct, then cat-blob can't be used
between filemodify | filedelete | filecopy | filerename | filedeleteall
| notemodify either...

Mike