From: Mike Hommey Date: Thu, 27 Nov 2014 22:01:43 GMT Subject: Re: [PATCH] fast-import: support the ls command anywhere comments are accepted Message-ID: <20141127220143.GA2554@glandium.org> In-Reply-To: <20141125230333.GA11114@glandium.org> On Wed, Nov 26, 2014 at 08:03:33AM +0900, Mike Hommey wrote: > On Wed, Nov 26, 2014 at 07:25:39AM +0900, Mike Hommey wrote: > > The git-fast-import manual page says about both cat-blob and ls that they can > > be used "anywhere in the stream that comments are accepted", but in practice > > it turns out it was only true for cat-blob. This change makes fast-import > > behavior match its documentation. > > > > Signed-off-by: Mike Hommey > > --- > > fast-import.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > The downside of this change is that if a script relies on the fixed behavior, > > it won't work with older versions of git. I'm not sure it is better than > > fixing the documentation to match the unfortunate current limitation? > > Note, if my reading of the code is correct, then cat-blob can't be used > between filemodify | filedelete | filecopy | filerename | filedeleteall > | notemodify either... Any thought on whether to fix those or to fix the documentation instead? Mike