Re: [PATCH v2 3/3] test-lib.sh: support -x option for shell-tracing

From: Jeff King <peff@peff.net>
Date: Oct 14, 2014, 00:46 UTC
Message-ID: <20141014004623.GA22910@peff.net>
In-Reply-To: <xmqq4mv71s0c.fsf@gitster.dls.corp.google.com>

On Mon, Oct 13, 2014 at 04:14:59PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> We came to more or less the same conclusion.  With your $*" fixed,
> the test "works" as before, with the same definition of "works",
> because without your patch the file ends with <HT>EOF<LF> and with
> your original $*<LF><HT>" the file ends with <HT>EOF<LF> with these
> extra <LF><HT> appended, which was what made me notice, and with $*"
> the file ends with the same <HT>EOF<LF> as before.

Yeah. I think the fact that fixing the test to properly respect EOF required you to later change the line number is a good indication that the test was broken in the first place. :)

> I've queued a fix for the original test on ta/config-set and also
> amended your $*".

Thanks. Note that my patch still technically adds a tab in front of the $*. I can't imagine that would matter, but if we wanted to be extra conservative, we would make it:

  eval "test ... && set -x
$*"

with no indentation at all.

> Enjoy your dinner ;-)

Thanks, I did. :)

-Peff