Re: [PATCH 2/3] t5304: use helper to report failure of "test foo = bar"

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 13, 2014, 21:31 UTC
Message-ID: <20141013213132.GA32245@google.com>
In-Reply-To: <20141013211524.GB15969@peff.net>

Jeff King wrote:

> On Mon, Oct 13, 2014 at 09:10:22AM -0700, Jonathan Nieder wrote:

Show 6 quoted lines

>> There's another downside to that construct: it loses the exit
>> status from some_cmd.
>
> Yes, although I think in many cases it's not a big deal. For example,
> here we lose the exit code of count-objects, but it also is very
> unlikely to fail _and_ produce our expected output.

It could segfault after producing the good output, but sure, count-objects code doesn't change very often.

[...]

Show 10 quoted lines

> One of my goals was to provide a more generic helper so that we don't
> have to make little helpers like this for every command. So I'd much
> rather something like:
>
>   test_output () {
> 	printf "%s\n" "$1" >expect &&
> 	shift &&
> 	"$@" >output &&
> 	test_cmp expect output
>   }

I agree with the principle in general.

Unfortunately that wouldn't help here --- the "$@" is a command with a pipe to sed in it and we still lose the exit status from count-objects.

Hoping that clarifies, Jonathan