Re: [PATCH 0/3] "-x" tracing option for tests

From: Jeff King <peff@peff.net>
Date: Oct 13, 2014, 21:07 UTC
Message-ID: <20141013210729.GA15969@peff.net>
In-Reply-To: <xmqqd29v4yl1.fsf@gitster.dls.corp.google.com>

On Mon, Oct 13, 2014 at 11:24:42AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > These patches are pulled out of the prune-mtime series I posted
> > earlier[1]. The discussion veered off and there's no reason that the two
> > topics need to be part of the same series.
> 
> These look all sensible.
> 
> Is your plan to reroll the prune-mtime stuff on top of these?  The
> additional safety those patches would give us is valuable and they
> are pretty straight-forward---I was hoping to have them in the 2.2
> release.

Yes, I've delayed while thinking about the issues that Michael raised. There are basically two paths I see:

  1. These do not solve all problems/races, but are a solid base and
     sensible path forward for further changes which we can worry about
     later.

  2. There is a better way to provide prune safety, and these patches
     will get in the way of doing that.

I wanted to make sure we are on path (1) and not path (2). :)

I'll try to send out a re-roll tonight.

-Peff