git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] fast-import: clean up pack_data pointer in end_packfile

From
Jeff King <peff@peff.net>
Date
Aug 25, 2014, 18:55 UTC
Message-ID
<20140825185534.GA30953@peff.net>
In-Reply-To
<CAL=YDWmC9ncuH=fLR=8PWuB=kJeRP-O3K9MCKGaDfoxF6WWb8A@mail.gmail.com>
On Mon, Aug 25, 2014 at 10:16:52AM -0700, Ronnie Sahlberg wrote:
> Print an error before returning when pack_data is NULL ?

I don't think so. We call end_packfile in some code paths (like the die handler) as "close if it's open". So I think it makes sense for it to be a noop if nothing is open.

-Peff
Previous: Ronnie SahlbergNext: Jeff King
Message 6 of 14 in “fix pack-refs pruning of refs/foo”
  1. 0/5 fix pack-refs pruning of refs/fooJeff King, Aug 23, 2014
  2. 1/5 git-prompt: do not look for refs/stash in $GIT_DIRJeff King, Aug 23, 2014
  3. 2/5 pack-refs: prune top-level refs like "refs/foo"Jeff King, Aug 23, 2014
  4. 3/5 fast-import: clean up pack_data pointer in end_packfileJeff King, Aug 23, 2014
  5. Ronnie SahlbergAug 25, 2014
  6. Jeff KingAug 25, 2014
  7. 4/5 fast-import: fix buffer overflow in dump_tagsJeff King, Aug 23, 2014
  8. Ronnie SahlbergAug 25, 2014
  9. 5/5 fast-import: stop using lock_ref_sha1Jeff King, Aug 23, 2014
  10. Ronnie SahlbergAug 25, 2014
  11. Michael HaggertyAug 23, 2014
  12. Jeff KingAug 23, 2014
  13. Ronnie SahlbergAug 25, 2014
  14. Jeff KingAug 25, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.