From: Jeff King <peff@peff.net>
Date: Mon, 25 Aug 2014 18:55:34 GMT
Subject: Re: [PATCH 3/5] fast-import: clean up pack_data pointer in end_packfile
Message-ID: <20140825185534.GA30953@peff.net>
In-Reply-To: <CAL=YDWmC9ncuH=fLR=8PWuB=kJeRP-O3K9MCKGaDfoxF6WWb8A@mail.gmail.com>

On Mon, Aug 25, 2014 at 10:16:52AM -0700, Ronnie Sahlberg wrote:

> Print an error before returning when pack_data is NULL ?

I don't think so. We call end_packfile in some code paths (like the die
handler) as "close if it's open". So I think it makes sense for it to be
a noop if nothing is open.

-Peff