Re: [PATCH 0/5] fix pack-refs pruning of refs/foo
On Mon, Aug 25, 2014 at 10:38:56AM -0700, Ronnie Sahlberg wrote:
Show 13 quoted lines
> > [1/5]: git-prompt: do not look for refs/stash in $GIT_DIR
> > [2/5]: pack-refs: prune top-level refs like "refs/foo"
> > [3/5]: fast-import: clean up pack_data pointer in end_packfile
> > [4/5]: fast-import: fix buffer overflow in dump_tags
> > [5/5]: fast-import: stop using lock_ref_sha1
> >
>
> +1 on 1-3
> +1 on 4. While I have a similar fix in the transaction series, you
> should not need to wait for that series to address a security concern.
> 5: I think this one is not as urgent as the others so would prefer if
> it is dropped, just so it doesn't cause more merge conflicts than is
> already present in the transaction series.
OK, I think we're in agreement then. Thanks for looking them over.
-Peff