Re: [PATCH 2/7] move setting of object->type to alloc_* functions

From: Jeff King <peff@peff.net>
Date: Jul 13, 2014, 06:41 UTC
Message-ID: <20140713064116.GA4768@sigill.intra.peff.net>
In-Reply-To: <20140712180539.GA13806@sigill.intra.peff.net>

On Sat, Jul 12, 2014 at 02:05:39PM -0400, Jeff King wrote:

Show 8 quoted lines

> > I don't particularly like 'flag' here. (not a massive dislike, mind you:)
> > 
> > Perhaps: flag->object_type, type->node_type?
> > Or, if that's too verbose, maybe just: flag->type, type->node?
> 
> Me either, but as you noticed, type was taken. Your suggestions seem
> fine. We could also just do away with the macro as discussed earlier (we
> already do in the commit_node case, anyway...).

Thinking on this more, writing out the definitions is the only sane thing to do here, now that alloc_commit_node does not use the macro. Otherwise you are inviting people to modify the macro, but fail to notice that the commit allocator also needs updating.

Here's a re-roll. The interesting bit is the addition of the second patch (but the rest needed to be rebased on top).

  [1/8]: alloc.c: remove the alloc_raw_commit_node() function
  [2/8]: alloc: write out allocator definitions
  [3/8]: move setting of object->type to alloc_* functions
  [4/8]: parse_object_buffer: do not set object type
  [5/8]: add object_as_type helper for casting objects
  [6/8]: alloc: factor out commit index
  [7/8]: object_as_type: set commit index
  [8/8]: diff-tree: avoid lookup_unknown_object

-Peff