[PATCH 7/7] diff-tree: avoid lookup_unknown_object
- From
Jeff King <peff@peff.net>
- Date
- Jul 11, 2014, 08:50 UTC
- Message-ID
- <20140711085041.GG5625@sigill.intra.peff.net>
- In-Reply-To
- <20140711084141.GA5521@sigill.intra.peff.net>
We generally want to avoid lookup_unknown_object, because it results in allocating more memory for the object than may be strictly necessary.
In this case, it is used to check whether we have an already-parsed object before calling parse_object, to save us from reading the object from disk. Using lookup_object would be fine for that purpose, but we can take it a step further. Since this code was written, parse_object already learned the "check lookup_object" optimization; we can simply call parse_object directly.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/diff-tree.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/builtin/diff-tree.c b/builtin/diff-tree.c index ce0e019..1c4ad62 100644 --- a/builtin/diff-tree.c +++ b/builtin/diff-tree.c @@ -68,9 +68,7 @@ static int diff_tree_stdin(char *line) line[len-1] = 0; if (get_sha1_hex(line, sha1)) return -1; - obj = lookup_unknown_object(sha1); - if (!obj || !obj->parsed) - obj = parse_object(sha1); + obj = parse_object(sha1); if (!obj) return -1; if (obj->type == OBJ_COMMIT)
-- 2.0.0.566.gfe3e6b2