Re: [PATCH v6 08/10] commit: add for_each_mergetag()
- From
Christian Couder <chriscool@tuxfamily.org>
- Date
- Jul 8, 2014, 05:53 UTC
- Message-ID
- <20140708.075316.1145736046390054920.chriscool@tuxfamily.org>
- In-Reply-To
- <xmqqegxwby3l.fsf@gitster.dls.corp.google.com>
From: Junio C Hamano <gitster@pobox.com>
Show 17 quoted lines
> Christian Couder <chriscool@tuxfamily.org> writes: > >> In the same way as there is for_each_ref() to >> iterate on refs, it might be useful to have >> for_each_mergetag() to iterate on the mergetags >> of a given commit. >> >> Signed-off-by: Christian Couder <chriscool@tuxfamily.org> >> --- > > Heh, "might be useful" is an understatement ;-) We won't apply a > change that "might be useful" very lightly, but this refactoring > already uses the helper in existing code, showing that it *is* > useful, no? > > Let's have this early in the series, or perhaps even independent of > the "replace" series.
Ok, thanks, Christian.