git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 4/4] commit: Add commit.verbose configuration

From
Jeff King <peff@peff.net>
Date
Jun 17, 2014, 21:39 UTC
Message-ID
<20140617213926.GA18994@sigill.intra.peff.net>
In-Reply-To
<xmqqy4wvjjyu.fsf@gitster.dls.corp.google.com>
On Tue, Jun 17, 2014 at 02:37:45PM -0700, Junio C Hamano wrote:
Show 23 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Tue, Jun 17, 2014 at 02:39:00PM -0500, Caleb Thompson wrote:
> >
> >> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> >> index 35a4d06..471bd8f 100755
> >> --- a/t/t7507-commit-verbose.sh
> >> +++ b/t/t7507-commit-verbose.sh
> >> @@ -7,6 +7,10 @@ write_script check-for-diff <<-'EOF'
> >>  	exec grep '^diff --git' "$1"
> >>  EOF
> >>  
> >> +write_script check-for-no-diff <<-'EOF'
> >> +	! check-for-diff
> >> +EOF
> >
> > Don't you need "$PWD/" or similar here, since check-for-diff is not in our path?
> 
> I actually would prefer a simpler
> 
> 	! grep '^diff --git' "$1"
> 
> that does not depend on what other parts of the tests have done.

Yeah, if it is that simple, I would agree (I did not even look at the definition of check-for-diff, and assumed it was more complicated :) ).

-Peff
Previous: Junio C HamanoNext: Torstein Hegge
Message 10 of 12 in “commit: Add commit.verbose configuration”
  1. 0/4 commit: Add commit.verbose configurationCaleb Thompson, Jun 17, 2014
  2. 1/4 commit test: Use test_config instead of git-configCaleb Thompson, Jun 17, 2014
  3. Junio C HamanoJun 17, 2014
  4. Junio C HamanoJun 17, 2014
  5. 2/4 commit test: Use write_scriptCaleb Thompson, Jun 17, 2014
  6. 3/4 commit test: test_set_editor in each testCaleb Thompson, Jun 17, 2014
  7. 4/4 commit: Add commit.verbose configurationCaleb Thompson, Jun 17, 2014
  8. Jeff KingJun 17, 2014
  9. Junio C HamanoJun 17, 2014
  10. Jeff KingJun 17, 2014
  11. Torstein HeggeFeb 27, 2015
  12. Caleb ThompsonMar 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.