From: Jeff King <peff@peff.net>
Date: Tue, 17 Jun 2014 21:39:28 GMT
Subject: Re: [PATCH v6 4/4] commit: Add commit.verbose configuration
Message-ID: <20140617213926.GA18994@sigill.intra.peff.net>
In-Reply-To: <xmqqy4wvjjyu.fsf@gitster.dls.corp.google.com>

On Tue, Jun 17, 2014 at 02:37:45PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > On Tue, Jun 17, 2014 at 02:39:00PM -0500, Caleb Thompson wrote:
> >
> >> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> >> index 35a4d06..471bd8f 100755
> >> --- a/t/t7507-commit-verbose.sh
> >> +++ b/t/t7507-commit-verbose.sh
> >> @@ -7,6 +7,10 @@ write_script check-for-diff <<-'EOF'
> >>  	exec grep '^diff --git' "$1"
> >>  EOF
> >>  
> >> +write_script check-for-no-diff <<-'EOF'
> >> +	! check-for-diff
> >> +EOF
> >
> > Don't you need "$PWD/" or similar here, since check-for-diff is not in our path?
> 
> I actually would prefer a simpler
> 
> 	! grep '^diff --git' "$1"
> 
> that does not depend on what other parts of the tests have done.

Yeah, if it is that simple, I would agree (I did not even look at the
definition of check-for-diff, and assumed it was more complicated :) ).

-Peff