Re: [PATCH v6 1/4] commit test: Use test_config instead of git-config

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2014, 21:35 UTC
Message-ID: <xmqq38f3kymg.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqq8uovkytq.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> Caleb Thompson <caleb@calebthompson.io> writes:
>
>> Some of the tests in t/t7507-commit-verbose.sh were still using
>> git-config to set configuration. Change them to use the test_config
>> helper.
>
> "were still using" is only a half of the story, and we need to be
> more careful than that, though.

I'd rephrase it like so if I were doing this patch myself:

    Subject: t7507: use test_config instead of git-config
    
    Some of the tests in t/t7507-commit-verbose.sh uses git-config
    to set configuration, but the updated variable setting does not
    have to be used in later tests.
    
    Change them to use the test_config helper.