git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] Re: [PATCH] mingw: redefine the wrapper macro after the corresponding function

From
Stepan Kasal <kasal@ucw.cz>
Date
Jun 5, 2014, 15:13 UTC
Message-ID
<20140605151338.GA29385@camelia.ucw.cz>
In-Reply-To
<539083FB.6040707@gmail.com>
Hello Karsten,
On Thu, Jun 05, 2014 at 04:51:39PM +0200, Karsten Blees wrote:
> In the current msysgit HEAD, most of these #undef's can simply be
> removed or have already been removed [...]

not "most of." According to my quick count, 6 of 20 have been removed, 2 more can be removed. The remaining 12 do play their role. (The point you overlooked is that there are several socket related, like bind().)

> If you apply this patch in msysgit, you'll most likely get compile
> errors due to redefining macros.

It would be warnings only. But a quick test shows that redefining with identical definition does not trigger the warning.

Stepan
Previous: Karsten BleesNext: Karsten Blees
Message 3 of 11 in “mingw: redefine the wrapper macro after the corresponding function”
  1. mingw: redefine the wrapper macro after the corresponding functionStepan Kasal, Jun 5, 2014
  2. Karsten BleesJun 5, 2014
  3. Stepan KasalJun 5, 2014
  4. Karsten BleesJun 5, 2014
  5. Johannes SixtJun 5, 2014
  6. Karsten BleesJun 5, 2014
  7. Stepan KasalJun 6, 2014
  8. mingw: redefine the wrapper macro after the corresponding functionStepan Kasal, Jun 6, 2014
  9. Karsten BleesJun 6, 2014
  10. Stepan KasalJun 6, 2014
  11. Karsten BleesJun 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.