git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mingw: redefine the wrapper macro after the corresponding function

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jun 5, 2014, 14:51 UTC
Message-ID
<539083FB.6040707@gmail.com>
In-Reply-To
<20140605080519.GB28029@camelia.ucw.cz>
Am 05.06.2014 10:05, schrieb Stepan Kasal:
Show 6 quoted lines
> mingw.c defines several wrapper functionsi, like mingw_unlink().
> These wrappers are deployed by macros like this:
> 	#define unlink mingw_unlink
> The function itself is preceded by #undef, leaving the wrapper out
> of the game for the rest of mingw.c.
> 
In the current msysgit HEAD, most of these #undef's can simply be removed or have already been removed (e.g. there's no '#undef mingw_unlink'). The reason is that the mingw_unlink implementation calls the unicode version _wunlink, so there's no name clash here.
If you apply this patch in msysgit, you'll most likely get compile errors due to redefining macros.
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Stepan KasalNext: Stepan Kasal
Message 2 of 11 in “mingw: redefine the wrapper macro after the corresponding function”
  1. mingw: redefine the wrapper macro after the corresponding functionStepan Kasal, Jun 5, 2014
  2. Karsten BleesJun 5, 2014
  3. Stepan KasalJun 5, 2014
  4. Karsten BleesJun 5, 2014
  5. Johannes SixtJun 5, 2014
  6. Karsten BleesJun 5, 2014
  7. Stepan KasalJun 6, 2014
  8. mingw: redefine the wrapper macro after the corresponding functionStepan Kasal, Jun 6, 2014
  9. Karsten BleesJun 6, 2014
  10. Stepan KasalJun 6, 2014
  11. Karsten BleesJun 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.