From: Stepan Kasal Date: Thu, 05 Jun 2014 15:13:38 GMT Subject: Re: [msysGit] Re: [PATCH] mingw: redefine the wrapper macro after the corresponding function Message-ID: <20140605151338.GA29385@camelia.ucw.cz> In-Reply-To: <539083FB.6040707@gmail.com> Hello Karsten, On Thu, Jun 05, 2014 at 04:51:39PM +0200, Karsten Blees wrote: > In the current msysgit HEAD, most of these #undef's can simply be > removed or have already been removed [...] not "most of." According to my quick count, 6 of 20 have been removed, 2 more can be removed. The remaining 12 do play their role. (The point you overlooked is that there are several socket related, like bind().) > If you apply this patch in msysgit, you'll most likely get compile > errors due to redefining macros. It would be warnings only. But a quick test shows that redefining with identical definition does not trigger the warning. Stepan