git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] connect.c: replace signal() with sigaction()

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
May 31, 2014, 14:45 UTC
Message-ID
<20140531144516.GA22508@hudson.localdomain>
In-Reply-To
<5389B16B.6070004@gmail.com>
Chris,
On Sat, May 31, 2014 at 10:39:39PM +1200, Chris Packham wrote:
> On 31/05/14 08:58, Jeremiah Mahler wrote:
> > From signal(2) man page:
> > 
...
Show 8 quoted lines
> > -	signal(SIGCHLD, SIG_DFL);
> > +	memset(&sa, 0, sizeof(sa));
> > +	sa.sa_handler = SIG_DFL;
> > +	sigaction(SIGCHLD, &sa, 0);
> 
> I think this got lost in the wash with v1 but
> Documentation/CodingGuidelines says to use NULL here instead of 0.
> 
Got it.  Will be in to the next revision.
  sigaction(SIGCHLD, &sa, NULL);
Thanks,
-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
Previous: Chris Packham
Message 6 of 6 in “replace signal() with sigaction()”
  1. 0/2 replace signal() with sigaction()Jeremiah Mahler, May 30, 2014
  2. 1/2 compat/mingw.c: expand MinGW support for sigactionJeremiah Mahler, May 30, 2014
  3. 2/2 connect.c: replace signal() with sigaction()Jeremiah Mahler, May 30, 2014
  4. Andreas SchwabMay 30, 2014
  5. Chris PackhamMay 31, 2014
  6. Jeremiah MahlerMay 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.