From: Jeremiah Mahler <jmmahler@gmail.com>
Date: Sat, 31 May 2014 14:45:16 GMT
Subject: Re: [PATCH v2 2/2] connect.c: replace signal() with sigaction()
Message-ID: <20140531144516.GA22508@hudson.localdomain>
In-Reply-To: <5389B16B.6070004@gmail.com>

Chris,

On Sat, May 31, 2014 at 10:39:39PM +1200, Chris Packham wrote:
> On 31/05/14 08:58, Jeremiah Mahler wrote:
> > From signal(2) man page:
> > 
...
> > -	signal(SIGCHLD, SIG_DFL);
> > +	memset(&sa, 0, sizeof(sa));
> > +	sa.sa_handler = SIG_DFL;
> > +	sigaction(SIGCHLD, &sa, 0);
> 
> I think this got lost in the wash with v1 but
> Documentation/CodingGuidelines says to use NULL here instead of 0.
> 
Got it.  Will be in to the next revision.

  sigaction(SIGCHLD, &sa, NULL);

Thanks,
-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler