git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] replace signal() with sigaction()

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
May 30, 2014, 20:58 UTC
Message-ID
<cover.1401482787.git.jmmahler@gmail.com>

This is the second revision to the patch set to replace signal(2) with sigaction(2) [1].

As Johannes pointed out [2], replacing signal with sigaction would break MinGW compatibility. The first patch in this series addresses this problem by expanding the faux sigaction function in compat/mingw.c to support signals other than just SIGALRM. Details are in the patch description.

The second patch is a proof of concept. It converts signal to sigaction in a case where signal SIGCHILD was used. Previously this would have failed with MinGW since the faux sigaction function only supported SIGALRM. Now it works as expected.

I have tested these changes under Linux and under Windows 7 using Msysgit.

[1]: http://marc.info/?l=git&m=140125769223552&w=2 [2]: http://marc.info/?l=git&m=140126288325213&w=2

Jeremiah Mahler (2):
  compat/mingw.c: expand MinGW support for sigaction
  connect.c: replace signal() with sigaction()
 compat/mingw.c | 9 +++++----
 connect.c      | 5 ++++-
 2 files changed, 9 insertions(+), 5 deletions(-)
-- 
2.0.0.2.g1d11d5d
Next: Jeremiah Mahler
Message 1 of 6 in “replace signal() with sigaction()”
  1. 0/2 replace signal() with sigaction()Jeremiah Mahler, May 30, 2014
  2. 1/2 compat/mingw.c: expand MinGW support for sigactionJeremiah Mahler, May 30, 2014
  3. 2/2 connect.c: replace signal() with sigaction()Jeremiah Mahler, May 30, 2014
  4. Andreas SchwabMay 30, 2014
  5. Chris PackhamMay 31, 2014
  6. Jeremiah MahlerMay 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.