git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t6006-*.sh: Fix truncation tests

From
Alexey Shumkin <alex.crezoff@gmail.com>
Date
May 20, 2014, 14:34 UTC
Message-ID
<20140520143401.GA31750@ashu.dyn1.rarus.ru>
In-Reply-To
<20140520141936.GA30187@ashu.dyn1.rarus.ru>
On Tue, May 20, 2014 at 06:19:36PM +0400, Alexey Shumkin wrote:
Show 57 quoted lines
> On Tue, May 20, 2014 at 02:54:20PM +0100, Ramsay Jones wrote:
> > 
> > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> > ---
> > 
> > Hi Alexey,
> > 
> > If you need to re-roll your 'as/pretty-truncate' branch, could
> > you please squash the relevant parts of this patch into the
> > corresponding patches of your patch series. (ie this is a patch
> > against the head of the current pu branch ...).
> > 
> > Without this patch I get:
> > 
> >   $ ./t6006-rev-list-format.sh
> >   ok 1 - setup
> >   ok 2 - format percent
> >   ok 3 - format hash
> >   ok 4 - format tree
> >   ok 5 - format parents
> >   ok 6 - format author
> >   ok 7 - format committer
> >   ok 8 - format encoding
> >   ok 9 - format subject
> >   ./t6006-rev-list-format.sh: 152: ./t6006-rev-list-format.sh: Syntax error: "(" unexpected
> >   FATAL: Unexpected exit with code 2
> >   $ 
> Ooops, my fault.
> > 
> > (if you have bash as /bin/sh you get different but related errors).
> > The additional quoting suppresses the 'command redirection' errors, etc...
> It's strange but I do have Bash as /bin/sh and unfortunately I have no
> this error
> 
> AFAIU, Junio already applied my patches (existance of a branch
> as/pretty-truncate tells us that). So, we can only send other patches that
> fix errors brought with former patches.
> You can send, too.
> > 
> > Thanks.
> > 
> > ATB
> > Ramsay Jones
> > 
> >  t/t6006-rev-list-format.sh | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh
> > index 9bc089b..e1dec3e 100755
> > --- a/t/t6006-rev-list-format.sh
> > +++ b/t/t6006-rev-list-format.sh
> > @@ -149,7 +149,7 @@ commit $head1
> >  $added
> >  EOF
> >  
> > -test_format subject-truncated %<($truncate_count,trunc)%s <<EOF
> > +test_format subject-truncated %\<\($truncate_count,trunc\)%s <<EOF
BTW, I would quoted that values rather than escaped
Previous: Alexey ShumkinNext: Ramsay Jones
Message 3 of 11 in “t6006-*.sh: Fix truncation tests”
  1. t6006-*.sh: Fix truncation testsRamsay Jones, May 20, 2014
  2. Alexey ShumkinMay 20, 2014
  3. Alexey ShumkinMay 20, 2014
  4. Ramsay JonesMay 20, 2014
  5. Alexey ShumkinMay 20, 2014
  6. Ramsay JonesMay 20, 2014
  7. Junio C HamanoMay 20, 2014
  8. Alexey ShumkinMay 21, 2014
  9. t6006 (rev-list-format): quote format strings to avoid error on some shellsAlexey Shumkin, May 20, 2014
  10. Ramsay JonesMay 20, 2014
  11. Alexey ShumkinMay 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.