From: Jeremiah Mahler Date: Sat, 17 May 2014 15:22:19 GMT Subject: Re: [PATCH] Documentation/technical/api-hashmap: Remove source highlighting Message-ID: <20140517152219.GA31912@hudson.localdomain> In-Reply-To: On Sat, May 17, 2014 at 07:08:55AM -0400, Anders Kaseorg wrote: > The highlighting was pretty, but unfortunately, the failure mode when > source-highlight is not installed was that the entire code block > disappears. See https://bugs.debian.org/745591, > https://bugs.launchpad.net/bugs/1316810. > I agree that a broken document is an unacceptable failure mode. But I do not understand why 'source-highlight' is not an install requirement for 'git-doc'. If I install 'source-highlight' on my Debian machine the code looks great. apt-get install source-highlight I also noticed that this seems to be the single place where source code highlighting is used in Documentation/technical. So it might be worthwhile to eliminate this dependency all together as Anders patch does. -- Jeremiah Mahler jmmahler@gmail.com http://github.com/jmahler