Re: [PATCH] Define constants for lengths of object names

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 1, 2014, 23:05 UTC
Message-ID: <20140501230553.GE9218@google.com>
In-Reply-To: <20140501230041.GC75770@vauxhall.crustytoothpaste.net>

brian m. carlson wrote:

> On Thu, May 01, 2014 at 10:20:07AM -0700, Jonathan Nieder wrote:

Show 16 quoted lines

>> What happened to the
>>
>> 	struct object_id {
>> 		unsigned char id[20];
>> 	};
>>
>> 	...
>>
>> 	struct object {
>> 		...
>> 		struct object_id id;
>> 	};
>>
>> idea?
>
> There didn't seem to be a huge amount of support for it.

I can make up for it in enthuasiasm. Please? It's something I've wanted for a long time but never found the time to do.

>                                                           Also, there
> were concerns that some architectures might impose alignment constraints
> on it that made sizeof(struct object_id) != 20.

Sounds awful.  What architecture?

Thanks, Jonathan