git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] Propagating flags carefully from the command line

From
Jeff King <peff@peff.net>
Date
Jan 21, 2014, 05:27 UTC
Message-ID
<20140121052708.GB5878@sigill.intra.peff.net>
In-Reply-To
<1389830384-22851-1-git-send-email-gitster@pobox.com>
On Wed, Jan 15, 2014 at 03:59:42PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> So this is my second try.  The second one now gets rid of the call
> to mark_blob_uninteresting() as Peff suggested, because the first
> patch makes the function very well aware that it only should mark
> the objects that are reachable from the object, and by definition
> blobs do not reach anything.
> 
> Junio C Hamano (2):
>   revision: mark contents of an uninteresting tree uninteresting
>   revision: propagate flag bits from tags to pointees

Sorry for a slow review, but I just read through your earlier comments and this series. I agree there was definitely a bug in what we were discussing earlier, and this looks like the right way to fix it. The end result splits the flag-setting responsibility much more sensibly.

Thanks.
-Peff
Previous: Junio C Hamano
Message 6 of 6 in “Propagating flags carefully from the command line”
  1. 0/2 Propagating flags carefully from the command lineJunio C Hamano, Jan 15, 2014
  2. 1/2 revision: mark contents of an uninteresting tree uninterestingJunio C Hamano, Jan 15, 2014
  3. Jonathan NiederJan 16, 2014
  4. Junio C HamanoJan 16, 2014
  5. 2/2 revision: propagate flag bits from tags to pointeesJunio C Hamano, Jan 15, 2014
  6. Jeff KingJan 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.