From: Jeff King Date: Tue, 21 Jan 2014 05:27:09 GMT Subject: Re: [PATCH v2 0/2] Propagating flags carefully from the command line Message-ID: <20140121052708.GB5878@sigill.intra.peff.net> In-Reply-To: <1389830384-22851-1-git-send-email-gitster@pobox.com> On Wed, Jan 15, 2014 at 03:59:42PM -0800, Junio C Hamano wrote: > So this is my second try. The second one now gets rid of the call > to mark_blob_uninteresting() as Peff suggested, because the first > patch makes the function very well aware that it only should mark > the objects that are reachable from the object, and by definition > blobs do not reach anything. > > Junio C Hamano (2): > revision: mark contents of an uninteresting tree uninteresting > revision: propagate flag bits from tags to pointees Sorry for a slow review, but I just read through your earlier comments and this series. I agree there was definitely a bug in what we were discussing earlier, and this looks like the right way to fix it. The end result splits the flag-setting responsibility much more sensibly. Thanks. -Peff