git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] revision: mark contents of an uninteresting tree uninteresting

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 16, 2014, 00:16 UTC
Message-ID
<20140116001607.GN18964@google.com>
In-Reply-To
<1389830384-22851-2-git-send-email-gitster@pobox.com>
Junio C Hamano wrote:
> we see the top-level tree marked as uninteresting (i.e. ^A^{tree} in
> the above example) and call mark_tree_uninteresting() on it; this
> unfortunately prevents us from recursing into the tree and marking
> the objects in the tree as uninteresting.

So the tree is marked uninteresting twice --- once by setting in the UNINTERESTING flag in handle_revision_arg() and a second attempted time in mark_tree_uninteresting()? Makes sense.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 6 in “Propagating flags carefully from the command line”
  1. 0/2 Propagating flags carefully from the command lineJunio C Hamano, Jan 15, 2014
  2. 1/2 revision: mark contents of an uninteresting tree uninterestingJunio C Hamano, Jan 15, 2014
  3. Jonathan NiederJan 16, 2014
  4. Junio C HamanoJan 16, 2014
  5. 2/2 revision: propagate flag bits from tags to pointeesJunio C Hamano, Jan 15, 2014
  6. Jeff KingJan 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.