Re: [PATCH 0/3] t0000 cleanups
- From
Jeff King <peff@peff.net>
- Date
- Jan 3, 2014, 01:04 UTC
- Message-ID
- <20140103010444.GA13018@sigill.intra.peff.net>
- In-Reply-To
- <20140102222833.GR20443@google.com>
On Thu, Jan 02, 2014 at 02:28:33PM -0800, Jonathan Nieder wrote:
Show 7 quoted lines
> > This is not exactly true. The TEST_OUTPUT_DIRECTORY setting does not > > leak. t0000 sets $TEST_DIRECTORY (which it must, so the sub-scripts can > > find test-lib.sh and friends), and then TEST_OUTPUT_DIRECTORY uses that > > as a default if it is not explicitly set. > > So I should have said something like the following instead: > [...]
Yes, looks good to me.
-Peff