git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t0000: drop "known breakage" test

From
Jeff King <peff@peff.net>
Date
Dec 29, 2013, 07:22 UTC
Message-ID
<20131229072227.GB31788@sigill.intra.peff.net>
In-Reply-To
<20131228205104.GA5544@google.com>
On Sat, Dec 28, 2013 at 12:51:04PM -0800, Jonathan Nieder wrote:
Show 8 quoted lines
> Jeff King wrote:
> 
> > I am not _that_ bothered by the "known breakage", but AFAICT there is
> > zero benefit to keeping this redundant test.
> 
> Devil's advocate: it ensures that anyone wrapping git's tests (like
> the old smoketest infrastructure experiment) is able to handle an
> expected failure.

Thanks. One of the things I love about open source is that as soon as I say "I can't see how...", the answer is crowd-sourced for me. :)

That being said, even if the test has a non-zero possible value...
> But in practice I don't mind the behavior before or after this patch.
> If the test harness is that broken, we'll know.  And people writing
> code that wraps git's tests can write their own custom sanity-checks.

...I think for these reasons that the value is smaller than the disruption caused by the test, and the patch is a net win.

-Peff
Previous: Jonathan NiederNext: Jonathan Nieder
Message 10 of 18 in “t0000 cleanups”
  1. 0/3 t0000 cleanupsJeff King, Dec 28, 2013
  2. 1/3 t0000: set TEST_OUTPUT_DIRECTORY for sub-testsJeff King, Dec 28, 2013
  3. Jonathan NiederDec 28, 2013
  4. Jonathan NiederDec 28, 2013
  5. Jeff KingDec 29, 2013
  6. 2/3 t0000: simplify HARNESS_ACTIVE hackJeff King, Dec 28, 2013
  7. Jonathan NiederDec 28, 2013
  8. 3/3 t0000: drop "known breakage" testJeff King, Dec 28, 2013
  9. Jonathan NiederDec 28, 2013
  10. Jeff KingDec 29, 2013
  11. Jonathan NiederDec 28, 2013
  12. Junio C HamanoDec 30, 2013
  13. Jonathan NiederDec 30, 2013
  14. Junio C HamanoDec 30, 2013
  15. Jeff KingDec 31, 2013
  16. Jonathan NiederJan 2, 2014
  17. Junio C HamanoJan 2, 2014
  18. Jeff KingJan 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.